Skip to content

[SyntaxParse] Fix attribute generation in ASTGen #27528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Oct 3, 2019

For the intermediate lookup table of the parsed decl attributes, use location the first token of the attributes instead of the start location of the parsed attribute list because some attributes can be ignored during the parsing.

rdar://problem/55952739

For the intermediate lookup table of the parsed decl attributes, use
location the first token of the attributes instead of the start location
of the *parsed* attribute list because some attributes can be ignored
during the parsing.

rdar://problem/55952739
@rintaro
Copy link
Member Author

rintaro commented Oct 3, 2019

@swift-ci Please smoke test

@rintaro rintaro requested a review from nathawes October 3, 2019 20:01
Copy link
Contributor

@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Rintaro!

@rintaro rintaro merged commit 2ddba9c into swiftlang:master Oct 3, 2019
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
…dar55952739"

This reverts commit 2ddba9c, reversing
changes made to 33770fa.
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants