Skip to content

Remove special case for swift-ci in update-checkout. #27538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Remove special case for swift-ci in update-checkout. #27538

merged 1 commit into from
Oct 8, 2019

Conversation

varungandhi-apple
Copy link
Contributor

Haven't filed a Radar with suggestions yet, will do so shortly.

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please smoke test

@jrose-apple
Copy link
Contributor

Why this change? It'll pick something in the middle of a merge that's never been tested.

@shahmishal
Copy link
Member

We can update this to check if it's merge commit, however it does not have to be Swift CI merge commit.

@varungandhi-apple
Copy link
Contributor Author

Updated with --merges flag.

@jrose-apple
Copy link
Contributor

That's still not good enough, since upstream-with-swift contains merges as well. How about --first-parent?

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please smoke test

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please smoke test Linux

Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@varungandhi-apple varungandhi-apple merged commit 8f55e42 into swiftlang:master Oct 8, 2019
@varungandhi-apple varungandhi-apple deleted the vg-update-update-checkout branch October 8, 2019 17:37
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants