Skip to content

Use .gitattributes to syntax-highlight GYB templates on GitHub #27540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

broadwaylamb
Copy link
Contributor

No description provided.

Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gottesmm
Copy link
Contributor

gottesmm commented Oct 4, 2019

@swift-ci smoke test and merge

@gottesmm
Copy link
Contributor

gottesmm commented Oct 4, 2019

For those listening in. This is implementing support for this: https://github.com/github/linguist#using-gitattributes.

@gottesmm
Copy link
Contributor

gottesmm commented Oct 4, 2019

@swift-ci smoke test linux platform

@broadwaylamb
Copy link
Contributor Author

I'm not sure how the failing test is related…

@compnerd
Copy link
Member

compnerd commented Oct 8, 2019

@swift-ci please smoke test Linux platform

@gottesmm
Copy link
Contributor

gottesmm commented Oct 8, 2019

@swift-ci smoke test Linux platform

@gottesmm
Copy link
Contributor

gottesmm commented Oct 8, 2019

Lets try this one more time... Sorry @broadwaylamb there was recently some breakage on Linux that had been messing with normal testing. I think it is resolved now.

@broadwaylamb
Copy link
Contributor Author

The Linux tests are passing now.

By the way, I'm just curious, why do we need to run tests if this PR doesn't change any actual code? 😊

@gottesmm
Copy link
Contributor

@broadwaylamb we require all PRs to go through testing to maintain an always green state of trunk. Also, there are certain tests that we run via the normal test suite that tests non-code properties (such as linting).

That being said, I do think that with the proper time/etc what you are suggesting could be done via a whitelist for docs/etc. We are just not there yet and this is a safe default.

Just MHO.

@gottesmm gottesmm merged commit 813dfc4 into swiftlang:master Oct 10, 2019
@broadwaylamb broadwaylamb deleted the patch-2 branch October 10, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants