[Runtime] Refactor HeapObject override checks to use a macro. #27542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test and merge |
|
@swift-ci please test linux platform |
|
Build failed |
jrose-apple
reviewed
Oct 4, 2019
stdlib/public/runtime/HeapObject.cpp
Outdated
| // to the call. This checks for an override in the function pointer. If an | ||
| // override is present, it calls that override. Otherwise it directly calls | ||
| // the default implementation. This allows the compiler to inline the default | ||
| // implementation and avoid the penformance penalty of indirecting through |
There was a problem hiding this comment.
Argh. You're not even the first one to point this out. I'm just bad at fixing it.
This gives us a one-stop shop for making changes to the override mechanism. rdar://problem/54752086
mikeash
force-pushed
the
retain-release-refactor
branch
from
85e1bd9 to
922b71f
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us a one-stop shop for making changes to the override mechanism.
rdar://problem/54752086