[AutoDiff upstream] Add `@transpose` attribute. #27545

saeta · 2019-10-04T18:23:22Z

The @transpose(of:) attribute registers a function as a transpose of another
function. This patch adds the @transpose(of:) attribute definition, syntax,
parsing, and printing.

Resolves TF-827.

Examples:

extension FloatingPoint where Self: Differentiable {
    @transpose(of: +)
    static func transposeAdd(_ v: Self) -> (Self, Self) { (v, v) }

    @transpose(of: *, wrt: 0)
    @transpose(of: *, wrt: 1)
    static func transposeMultiply(lhs: Self, rhs: Self) -> Self { lhs * rhs }
}

The differentiable programming manifesto has more information and examples.

Note: this code is upstreamed from tensorflow branch.

Known todos and issues are referenced in comments:

Upstream @transpose attribute type-checking (TF-830, TF-1060).
Enable @transpose attribute serialization (TF-838).
Use module-qualified names instead of custom qualified name syntax/parsing
(TF-1066).

We would like to upstream code and continue development on master, if that's acceptable!

The `@transpose(of:)` attribute registers a function as a transpose of another function. This patch adds the `@transpose(of:)` attribute definition, syntax, parsing, and printing. Resolves TF-827. Todos: - Type-checking (TF-830, TF-1060). - Enable serialization (TF-838). - Use module-qualified names instead of custom qualified name syntax/parsing (TF-1066).

dan-zheng · 2019-12-16T20:33:18Z

I revived this PR to upstream the current state of tensorflow branch, it is now ready for review. cc @rxwei @lattner

The PR description tracks todos and known issues.

lattner

Nice!

include/swift/AST/Attr.h

test/AutoDiff/Parse/transpose_attr_parse.swift

lib/AST/ASTContext.cpp

…se-attr

Update gyb-generated files for `@transpose` attribute. Friend PR: swiftlang/swift#27545

dan-zheng · 2019-12-17T20:53:31Z

swiftlang/swift-syntax#189
@swift-ci Please test

swift-ci · 2019-12-17T20:54:09Z

Build failed
Swift Test OS X Platform
Git Sha - c842fee

swift-ci · 2019-12-17T20:56:02Z

Build failed
Swift Test Linux Platform
Git Sha - c842fee

dan-zheng · 2019-12-17T23:00:48Z

CI failed for test/IDE/complete_decl_attribute.swift but the test passes for me locally.
Perhaps a clean test is necessary, I'll try it now.

dan-zheng · 2019-12-17T23:00:57Z

swiftlang/swift-syntax#189
@swift-ci Please clean test

lib/Parse/ParseType.cpp

test/AutoDiff/Parse/transpose_attr_parse.swift

utils/gyb_syntax_support/AttributeNodes.py

Use it in both `Parser::canParseTypeIdentifier` and `Parser::canParseBaseTypeForQualifiedDeclName`.

rintaro

Parser/Syntax changes look good!

Update gyb-generated files for `@transpose` attribute. Friend PR: swiftlang/swift#27545

dan-zheng · 2019-12-18T02:04:15Z

swiftlang/swift-syntax#189
@swift-ci Please clean test

swift-ci · 2019-12-18T02:04:45Z

Build failed
Swift Test Linux Platform
Git Sha - cd1400d

swift-ci · 2019-12-18T02:04:57Z

Build failed
Swift Test OS X Platform
Git Sha - cd1400d

Update gyb-generated files for `@transpose` attribute. Friend PR: swiftlang/swift#27545

saeta requested review from dan-zheng, beccadax, rxwei, marcrasi and bgogul and removed request for dan-zheng October 4, 2019 18:23

dan-zheng force-pushed the transposing-attr branch from b7415d2 to 58c5d4d Compare December 16, 2019 20:21

dan-zheng requested review from lattner and DougGregor and removed request for marcrasi, bgogul and beccadax December 16, 2019 20:21

dan-zheng force-pushed the transposing-attr branch from 58c5d4d to c842fee Compare December 16, 2019 20:23

dan-zheng changed the title ~~[AutoDiff upstream] Introduce @transposing attribute.~~ [AutoDiff upstream] Add @transpose attribute. Dec 16, 2019

lattner approved these changes Dec 17, 2019

View reviewed changes

include/swift/AST/Attr.h Outdated Show resolved Hide resolved

test/AutoDiff/Parse/transpose_attr_parse.swift Show resolved Hide resolved

rxwei approved these changes Dec 17, 2019

View reviewed changes

lib/AST/ASTContext.cpp Outdated Show resolved Hide resolved

Clarify @derivative(of:) and @transpose(of:) attribute names.

b94c097

dan-zheng marked this pull request as ready for review December 17, 2019 20:05

dan-zheng added 2 commits December 17, 2019 12:17

Fix qualified name parsing syntax verification errors.

aecf9a1

Merge branch 'master' of github.com:apple/swift into upstream-transpo…

cd1400d

…se-attr

dan-zheng added a commit to dan-zheng/swift-syntax that referenced this pull request Dec 17, 2019

[AutoDiff upstream] Update gyb-generated files.

5959011

Update gyb-generated files for `@transpose` attribute. Friend PR: swiftlang/swift#27545

dan-zheng mentioned this pull request Dec 17, 2019

[AutoDiff upstream] Update gyb-generated files. swiftlang/swift-syntax#189

Merged

rintaro reviewed Dec 17, 2019

View reviewed changes

lib/Parse/ParseType.cpp Outdated Show resolved Hide resolved

test/AutoDiff/Parse/transpose_attr_parse.swift Show resolved Hide resolved

utils/gyb_syntax_support/AttributeNodes.py Outdated Show resolved Hide resolved

utils/gyb_syntax_support/AttributeNodes.py Show resolved Hide resolved

dan-zheng added 2 commits December 17, 2019 16:21

Address parsing/syntax review feedback.

c736938

Create shared utility Parser::canParseSimpleTypeIdentifier.

fa31c75

Use it in both `Parser::canParseTypeIdentifier` and `Parser::canParseBaseTypeForQualifiedDeclName`.

dan-zheng requested a review from rintaro December 18, 2019 00:37

rintaro approved these changes Dec 18, 2019

View reviewed changes

dan-zheng added a commit to dan-zheng/swift-syntax that referenced this pull request Dec 18, 2019

[AutoDiff upstream] Update gyb-generated files.

d1cc432

Update gyb-generated files for `@transpose` attribute. Friend PR: swiftlang/swift#27545

akyrtzi merged commit a9c9f26 into master Dec 18, 2019

dan-zheng deleted the transposing-attr branch December 18, 2019 20:01

dan-zheng added a commit to dan-zheng/swift-syntax that referenced this pull request Apr 8, 2020

[AutoDiff upstream] Update gyb-generated files.

c8e4fef

Update gyb-generated files for `@transpose` attribute. Friend PR: swiftlang/swift#27545

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[AutoDiff upstream] Add `@transpose` attribute. #27545

[AutoDiff upstream] Add `@transpose` attribute. #27545

Uh oh!

saeta commented Oct 4, 2019 •

edited by dan-zheng

Loading

Uh oh!

dan-zheng commented Dec 16, 2019

Uh oh!

lattner left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dan-zheng commented Dec 17, 2019

Uh oh!

swift-ci commented Dec 17, 2019

Uh oh!

swift-ci commented Dec 17, 2019

Uh oh!

dan-zheng commented Dec 17, 2019

Uh oh!

dan-zheng commented Dec 17, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rintaro left a comment

Uh oh!

dan-zheng commented Dec 18, 2019

Uh oh!

swift-ci commented Dec 18, 2019

Uh oh!

swift-ci commented Dec 18, 2019

Uh oh!

Uh oh!

[AutoDiff upstream] Add @transpose attribute. #27545

[AutoDiff upstream] Add @transpose attribute. #27545

Uh oh!

Conversation

saeta commented Oct 4, 2019 • edited by dan-zheng Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dan-zheng commented Dec 16, 2019

Uh oh!

lattner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dan-zheng commented Dec 17, 2019

Uh oh!

swift-ci commented Dec 17, 2019

Uh oh!

swift-ci commented Dec 17, 2019

Uh oh!

dan-zheng commented Dec 17, 2019

Uh oh!

dan-zheng commented Dec 17, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rintaro left a comment

Choose a reason for hiding this comment

Uh oh!

dan-zheng commented Dec 18, 2019

Uh oh!

swift-ci commented Dec 18, 2019

Uh oh!

swift-ci commented Dec 18, 2019

Uh oh!

Uh oh!

[AutoDiff upstream] Add `@transpose` attribute. #27545

[AutoDiff upstream] Add `@transpose` attribute. #27545

saeta commented Oct 4, 2019 •

edited by dan-zheng

Loading