Skip to content

[NFC] Add a short note on what USRs are and what they're used for. #27548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2019
Merged

[NFC] Add a short note on what USRs are and what they're used for. #27548

merged 1 commit into from
Oct 8, 2019

Conversation

varungandhi-apple
Copy link
Contributor

@varungandhi-apple varungandhi-apple commented Oct 5, 2019 •
edited
Loading

I didn't know what these were and couldn't find documentation so I figured I'd add some.

(Review from any person will do.)

nkcsgexi
nkcsgexi approved these changes Oct 5, 2019
View reviewed changes
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this!👍

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please smoke test and merge

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test Linux platform

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please smoke test Linux

@varungandhi-apple varungandhi-apple merged commit 5ce10d1 into swiftlang:master Oct 8, 2019
@varungandhi-apple varungandhi-apple deleted the vg-document-USR branch October 8, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcsgexi nkcsgexi nkcsgexi approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varungandhi-apple @nkcsgexi