Skip to content

Circular validation cleanups, part 4 #27553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Oct 5, 2019

Follow-up to #27546 which completes the changeover to make ValueDecl::getInterfaceType() return ErrorType on circularity, instead of an empty Type.

@slavapestov slavapestov force-pushed the circular-validation-cleanups-4 branch from f622df7 to 7be7f6c Compare October 7, 2019 20:57
@slavapestov slavapestov force-pushed the circular-validation-cleanups-4 branch from 7be7f6c to 6e70b39 Compare October 8, 2019 05:37
@slavapestov slavapestov requested a review from CodaFi October 8, 2019 05:39
@slavapestov slavapestov marked this pull request as ready for review October 8, 2019 05:39
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov slavapestov merged commit 64224ca into swiftlang:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant