Skip to content

[tests] Add mechanism to override lit environment #27560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2019

Conversation

beccadax
Copy link
Contributor

@beccadax beccadax commented Oct 6, 2019

lit runs its tests with only the environment variables set up by its configuration, which is great for repeatability, but sometimes you want to allow a few controlled leaks. With this change, you can now specify --param copy_env=FOO:BAR:BAZ to cause the environment variables FOO, BAR, and BAZ to be visible in lit tests during that run.

lit runs its tests with only the environment variables set up by its configuration, which is great for repeatability, but sometimes you want to allow a few controlled leaks. With this change, you can now specify “--param copy_env=FOO:BAR:BAZ” to cause the environment variables FOO, BAR, and BAZ to be visible in lit tests during that run.
@beccadax beccadax requested a review from gottesmm October 6, 2019 23:19
@beccadax
Copy link
Contributor Author

beccadax commented Oct 6, 2019

@swift-ci please smoke test

@beccadax
Copy link
Contributor Author

beccadax commented Oct 7, 2019

Linux failure looks unrelated; I'm hoping it's intermittent.

@swift-ci please smoke test linux platform

@theblixguy
Copy link
Collaborator

Linux PR testing has been broken since a few days, it should be fixed by swiftlang/swift-corelibs-foundation#2532 when merged.

@beccadax
Copy link
Contributor Author

beccadax commented Oct 7, 2019

@swift-ci please smoke test

@stephentyrone
Copy link
Contributor

Linux PR testing has been broken since a few days, it should be fixed by apple/swift-corelibs-foundation#2532 when merged.

Unfortunately 2532 also fails to test, so I'm not sure where that puts us right now.

@beccadax
Copy link
Contributor Author

beccadax commented Oct 8, 2019

@swift-ci please smoke test linux platform

1 similar comment
@beccadax
Copy link
Contributor Author

beccadax commented Oct 8, 2019

@swift-ci please smoke test linux platform

@beccadax beccadax merged commit d034d2d into swiftlang:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants