Skip to content

[SkipFunctionBodies] Build everything but the stdlib with function body skipping #27588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

harlanhaskins
Copy link
Contributor

Per a conversation with @atrick, see what the impact is of building everything but the stdlib with function body skipping, so we can see if the issues are stdlib-specific. Granted, not many of the benchmarks use the overlays...

@harlanhaskins
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Oct 9, 2019

Build failed before running benchmark.

@harlanhaskins
Copy link
Contributor Author

@swift-ci please benchmark

@swift-ci
Copy link
Contributor

swift-ci commented Oct 9, 2019

Performance: -O

Improvement OLD NEW DELTA RATIO
ObjectiveCBridgeStubNSDataAppend 1660 1520 -8.4% 1.09x (?)

Code size: -O

Performance: -Osize

Regression OLD NEW DELTA RATIO
DropWhileSequence 13 14 +7.7% 0.93x (?)
 
Improvement OLD NEW DELTA RATIO
ArrayAppendGenericStructs 1520 590 -61.2% 2.58x (?)
ObjectiveCBridgeStubFromNSStringRef 91 85 -6.6% 1.07x (?)

Code size: -Osize

Performance: -Onone

Improvement OLD NEW DELTA RATIO
ArrayAppendGenericStructs 650 600 -7.7% 1.08x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@harlanhaskins
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Oct 9, 2019

Build failed
Swift Test OS X Platform
Git Sha - 5301fa0

@swift-ci
Copy link
Contributor

swift-ci commented Oct 9, 2019

Build failed
Swift Test Linux Platform
Git Sha - 5301fa0

@atrick
Copy link
Contributor

atrick commented Oct 9, 2019

No problems with the benchmarks. The standard library needs to be built specially anyway. For example, we can't parallelize the LLVM passes as we usually do because we too much benefit from cross-file optimization. I think it's the same with serialization. I don't expect regular frameworks to be so sensitive to this issue. Now, it's interesting that with resilience the compiler isn't supposed to be making any assumptions about the non-inlinable code, so it's probably worth following up on the compiler side to understand why it does things differently. But there's no harm done in this PR.

@harlanhaskins harlanhaskins marked this pull request as ready for review October 10, 2019 00:29
@harlanhaskins harlanhaskins changed the title [Experiment] Build everything but the stdlib with function body skipping [SkipFunctionBodies] Build everything but the stdlib with function body skipping Oct 10, 2019
@harlanhaskins harlanhaskins merged commit ce7aa3c into swiftlang:master Oct 10, 2019
harlanhaskins pushed a commit to harlanhaskins/swift that referenced this pull request Oct 17, 2019
…dy skipping

This un-revers swiftlang#27588, which was causing failures on debug builds
because it was only disabling the NonInlinableFunctionSkippingChecker
for the *optimized* OnoneSupport module, but not the unoptimized one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants