Skip to content

[SyntaxParse] Parse tuple/paren expression syntax #27592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2019
Merged

[SyntaxParse] Parse tuple/paren expression syntax #27592

merged 3 commits into from
Oct 10, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Oct 9, 2019

Also, added CodeCompletionExpr syntax for code completion tokens.

@rintaro
Copy link
Member Author

rintaro commented Oct 9, 2019

@swift-ci Please test

@rintaro rintaro requested a review from nathawes October 9, 2019 21:56
@swift-ci
Copy link
Contributor

swift-ci commented Oct 9, 2019

Build failed
Swift Test Linux Platform
Git Sha - ebbc9c8

@swift-ci
Copy link
Contributor

swift-ci commented Oct 9, 2019

Build failed
Swift Test OS X Platform
Git Sha - ebbc9c8

@rintaro
[Syntax] Include leading/trailing trivia size to the cache ID
33e561a 
We have to differenciate cache IDs between:
  (Token l_brace
    (trivia space 1)
    (text="{"))
and:
  (Token l_brace
    (text="{")
    (trivia space 1))
@rintaro
Copy link
Member Author

rintaro commented Oct 10, 2019

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ebbc9c8

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ebbc9c8

@rintaro rintaro merged commit cdfd1ab into swiftlang:master Oct 10, 2019
@rintaro rintaro deleted the syntaxparse-exprtuple branch October 10, 2019 17:58
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Merge pull request swiftlang#27592 from rintaro/syntaxparse-e…
0e8010d 
…xprtuple"

This reverts commit cdfd1ab, reversing
changes made to eb02f20.
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Revert "Merge pull request swiftlang#27592 from rintaro/synta…
b2461d8 
…xparse-exprtuple""

This reverts commit 0e8010d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathawes nathawes Awaiting requested review from nathawes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @swift-ci