[ome] Just erase the destructure rather than trying to get rid of dea… #27599
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
eeckstein
requested changes
Oct 10, 2019
|
@eeckstein I do! Sorry I didn't add it to the PR! Thanks for catching that! |
…d instructions due to simplifyInstruction. This ensures that we do not run into any iterator invalidation issues. It does worsen the passes output slightly, but avoiding the complexity is worth it and other later passes will clean up the dead code. rdar://55811732
gottesmm
force-pushed
the
pr-b367ebec31812f3fe81f71280f06107d97e18318
branch
from
7a2b250 to
1b29d86
Compare
|
@swift-ci smoke test |
eeckstein
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d instructions due to simplifyInstruction.
This ensures that we do not run into any iterator invalidation issues. It does
worsen the passes output slightly, but avoiding the complexity is worth it and
other later passes will clean up the dead code.
rdar://55811732