Skip to content

[AutoDiff] Rename "associated function" to "derivative function". #27603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 10, 2019

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Oct 10, 2019

assocFn -> derivativeFn
AssocFn -> DerivativeFn
assocFunc -> derivativeFunc
AssocFunc -> DerivativeFunc
associatedFunction -> derivativeFunction
AssociatedFunction -> DerivativeFunction
autodiff associated function -> derivative function
autodiff-associated function -> derivative function
AD associated function -> derivative function
associated differentiation function -> derivative function

This is a follow-up to #27597.

Resolves TF-882.

@rxwei rxwei added the tensorflow This is for "tensorflow" branch PRs. label Oct 10, 2019
@rxwei rxwei requested review from dan-zheng and bgogul October 10, 2019 18:05
@dan-zheng dan-zheng force-pushed the assocfn-derivativefn branch from b466e17 to f127d1b Compare October 10, 2019 18:12
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the renaming!

Verified no remaining results:

$ grep -nri "an derivative" include lib docs test
$ grep -nri "associated function" include lib docs test
$ grep -nri "assoc function" include lib docs test
$ grep -nri "assocfn" include lib docs test
$ grep -nri "assoc derivative" include lib docs test

associated derivative remains but I think it's okay:

$ grep -nri "associated derivative" include lib docs test
include/swift/AST/Attr.h:1529:/// custom associated derivative functions: 'jvp' and 'vjp'.
test/AutoDiff/forward_mode_runtime.swift:445:// Test case where associated derivative function's requirements are met.
test/AutoDiff/generics.swift:31:// Test case where associated derivative function's requirements are met.

@rxwei
Copy link
Contributor Author

rxwei commented Oct 10, 2019

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Oct 10, 2019

Thanks for verifying!

@rxwei rxwei merged commit 431cc43 into swiftlang:tensorflow Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tensorflow This is for "tensorflow" branch PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants