Skip to content

[SyntaxParse] Parse object literal and unresolved member expressions #27607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2019
Merged

[SyntaxParse] Parse object literal and unresolved member expressions #27607

merged 2 commits into from
Oct 11, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Oct 10, 2019

  • Object literals e.g. #imageLiteral(name: "ImageName")
  • Unresolved member expressions e.g. .rgb(1.0, 0.3, 8.2)

@rintaro
Copy link
Member Author

rintaro commented Oct 10, 2019

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 6a9b252

@rintaro rintaro requested a review from nathawes October 10, 2019 21:01
@rintaro
Copy link
Member Author

rintaro commented Oct 10, 2019

@swift-ci Please test macOS

@rintaro rintaro merged commit 5e1f790 into swiftlang:master Oct 11, 2019
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Merge pull request swiftlang#27607 from rintaro/syntaxparse-e…
b56c543 
…xprunresolvedmember"

This reverts commit 5e1f790, reversing
changes made to 1846a59.
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Revert "Merge pull request swiftlang#27607 from rintaro/synta…
59e623d 
…xparse-exprunresolvedmember""

This reverts commit b56c543.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathawes nathawes Awaiting requested review from nathawes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @swift-ci