[AutoDiff] Rename 'AutoDiffIndexSubset' to 'IndexSubset'. #27615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
changed the title
rxwei
force-pushed
the
rename-autodiff-index-subset
branch
from
1c5e135 to
cbe6f40
Compare
Per @DougGregor's review comment (swiftlang#27555 (comment)), `AutoDiffIndexSubset` data structure could have a more general name. We rename it to `IndexSubset` and move it to its own file.
rxwei
force-pushed
the
rename-autodiff-index-subset
branch
from
cbe6f40 to
81d0446
Compare
… into rename-autodiff-index-subset
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Oct 11, 2019
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @DougGregor's review comment (#27555 (comment)),
AutoDiffIndexSubsetdata structure could have a more general name. We rename it toIndexSubsetand move it to its own file.