Frontend: fix after #27464 #27618
Merged
Frontend: fix after #27464 #27618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
try to invoke a std::unique_ptr<>'s copy constructor, which is deleted. Either move the unique_ptr or pass along a nullptr. This should repair the Windows build.
|
@swift-ci please smoke test and merge |
|
CC: @nkcsgexi |
jrose-apple
reviewed
Oct 11, 2019
| return ModuleBuffers( | ||
| std::move(*inputFileOrErr), | ||
| openModuleDoc(input).getValueOr(nullptr), | ||
| openModuleSourceInfo(input).getValueOr(nullptr) |
There was a problem hiding this comment.
Boo, this shouldn't formally do a copy. :-( Can we update LLVM_HAS_RVALUE_REFERENCE_THIS in Compiler.h instead? Or does MSVC still not have it?
There was a problem hiding this comment.
I think that MSVC does support rvalue reference this (VS2019 probably does, VS2017 is what Im worried about). LLVM_HAS_RVALUE_REFERENCE_THIS was removed (by JF) recently actually IIRC.
There was a problem hiding this comment.
Looks like they got re-added. Oh well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to invoke a std::unique_ptr<>'s copy constructor, which is deleted.
Either move the unique_ptr or pass along a nullptr. This should repair
the Windows build.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.