disallow in-tree builds #27621
Merged
disallow in-tree builds #27621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake recommends against in-tree builds, most other projects like LLVM disable this support as well. Performing a configure in the tree can cause spurious files to be generated which can break the build. Simply prevent the user from doing so.
|
@swift-ci please smoke test |
|
CC: @jrose-apple |
DougGregor
approved these changes
Oct 11, 2019
jrose-apple
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake recommends against in-tree builds, most other projects like LLVM
disable this support as well. Performing a configure in the tree can
cause spurious files to be generated which can break the build. Simply
prevent the user from doing so.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.