Downgrade The TypeLoc in VarDecl to a TypeRepr #27624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeCheckPattern used to splat the interface type into this, and different parts of the compiler would check one or the other. There is now one source of truth: The interface type. The type repr is now just a signal that the user has written an explicit type annotation on a parameter. For variables, we will eventually be able to just grab this information from the parent pattern.
|
@swift-ci please smoke test |
CodaFi
commented
Oct 11, 2019
| if (auto ty = decl->getTypeLoc().getType()) | ||
| return; | ||
|
|
||
| static Type validateParameterType(ParamDecl *decl) { |
There was a problem hiding this comment.
Gee, this whole thing looks suspiciously requestifiable now
|
@swift-ci please smoke test |
CodaFi
changed the title
|
@swift-ci please smoke test |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeCheckPattern used to splat the interface type into this, and
different parts of the compiler would check one or the other. There is
now one source of truth: The interface type. The type repr is now just
a signal that the user has written an explicit type annotation on
a parameter. For variables, we will eventually be able to just grab
this information from the parent pattern.
EDIT: This started as a simple refactor, now I'm just nuking the old stateful code around this that we don't need anymore. There's diagnostic improvements from this.