-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[AutoDiff] SILGen differentiability witnesses. #27652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dan-zheng
merged 5 commits into
swiftlang:tensorflow
from
dan-zheng:sil-differentiability-witness
Oct 16, 2019
Merged
[AutoDiff] SILGen differentiability witnesses. #27652
dan-zheng
merged 5 commits into
swiftlang:tensorflow
from
dan-zheng:sil-differentiability-witness
Oct 16, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
commented
Oct 13, 2019
4d41c78
to
ab624b2
Compare
rxwei
reviewed
Oct 14, 2019
ab624b2
to
6f95bab
Compare
dan-zheng
commented
Oct 15, 2019
6f95bab
to
b2f2dfe
Compare
rxwei
reviewed
Oct 15, 2019
@swift-ci Please test tensorflow |
Generate SIL differentiability witnesses from AST `@differentiable` attributes, using lowered parameter indices, result indices (currently with capacity 1 and set index 0), and derivative generic signature. Resolves TF-869. The TF-866 master issue tracks all retroactive derivative registration tasks.
10d1847
to
8688777
Compare
@swift-ci Please test tensorflow |
CI fails due to differentiability witness deserialization failures (see occurrences of
These surfaced only after differentiability witness SILGen. EDIT: Fixed in 4c4bc43. |
Fix serialization for Serialization/differentia{ble,ting}_attr.swift.
Fix deserialization for Serialization/differentia{ble,ting}_attr.swift. TF-919 has more info.
8688777
to
1118fcd
Compare
@swift-ci Please test tensorflow |
rxwei
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate SIL differentiability witnesses from AST
@differentiable
attributes,using lowered parameter indices, result indices (currently with capacity 1 and
set index 0), and derivative generic signature.
Resolves TF-869.
The TF-866 master issue tracks all retroactive derivative registration tasks.
Todos related to this patch:
@differentiating
attribute to SIL[differentiable]
attribute instead of creating implicit@differentiable
attributes. This is blocked by full retroactive derivative registration, see issue comment for details.