Skip to content

Fixup a test #27679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2019
Merged

Fixup a test #27679

merged 1 commit into from
Oct 15, 2019

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Oct 15, 2019

Validation order changed.

Get the bots passing again.

@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 15, 2019

@swift-ci please smoke test

@theblixguy
Copy link
Collaborator

Thank you! (I was confused when the CI failed on one of my PRs).

@theblixguy theblixguy mentioned this pull request Oct 15, 2019
Merged
beccadax
beccadax reviewed Oct 15, 2019
View reviewed changes
Copy link
Contributor

@beccadax beccadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth merging anyway just to fix the build, but is this diagnostic actually accurate?

@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 15, 2019

The diagnostic is a catch-all introduced to cut off a crasher. We should be able to do much much better soon.

@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 15, 2019

⛵️

@CodaFi CodaFi merged commit bd94891 into swiftlang:master Oct 15, 2019
@CodaFi CodaFi deleted the unicycle branch October 15, 2019 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beccadax beccadax beccadax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodaFi @theblixguy @beccadax