[AutoDiff] NFC: Change DifferentiableFunctionExtractee to a top-level type.
#27688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el type.
Many places in the compiler that are completely unrelated to {{DifferentiableFunctionExtractInst}} are using {{DifferentiableFunctionExtractInst::Extractee}}, including `@differentiable` type lowering (IRGen/GenDiffFunc.cpp). This patch refactors it and renames it to `NormalDifferentiableFunctionTypeComponent` so that it is no longer part of `DifferentiableFunctionInst`.
Resolves [TF-904](https://bugs.swift.org/browse/TF-904).
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow linux cpu |
|
@swift-ci please test tensorflow cpu |
dan-zheng
approved these changes
Oct 15, 2019
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
Oct 15, 2019
A build failure was introduced in swiftlang#27688, but CI didn't catch it somehow. This patch fixes it.
rxwei
added a commit
that referenced
this pull request
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many places in the compiler that are completely unrelated to
DifferentiableFunctionExtractInstare usingDifferentiableFunctionExtractInst::Extractee, including@differentiabletype lowering (IRGen/GenDiffFunc.cpp). This patch refactors it and renames it toNormalDifferentiableFunctionTypeComponentso that it is no longer part ofDifferentiableFunctionInst.Resolves TF-904.