[AutoDiff] [SIL] Tweak 'differentiable_function' syntax. #27689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `differentiable_function` instruction's syntax, use `parameters` instead of `wrt` and 'with_derivative' instead of `with`. This is to align with `linear_function` instruction and the future direction that both parameter indices and result indices will be included in this instruction. Note: `with_derivative` is not named `with_derivatives` because VJPs will be dropped from this instruction when we complete JVP + linear map transposition. Resolves [TF-909](https://bugs.swift.org/browse/TF-909).
|
@swift-ci please test tensorflow |
dan-zheng
approved these changes
Oct 15, 2019
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
differentiable_functioninstruction's syntax, useparametersinstead ofwrtand 'with_derivative' instead ofwith. This is to align withlinear_functioninstruction and the future direction that both parameter indices and result indices will be included in this instruction.Note:
with_derivativeis not namedwith_derivativesbecause VJPs will be dropped from this instruction when we complete JVP + linear map transposition.Resolves TF-909.