A handful of independent changes from #27695 #27696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array-to-pointer should only be used for such conversions. This isn't currently an issue as we short-circuit disjunctions upon successfully solving an array-to-pointer conversion. However this would become an issue if only inout-to-pointer was viable.
This lets us add a constraint to the system with an associated fix. Unlike `addUnsolvedConstraint`, this will attempt to immediately simplify the constraint, producing an unsolved constraint if necessary.
|
@swift-ci please smoke test |
|
This looks like FC to me :) |
hamishknight
changed the title
|
@xedin Fair enough :) Note though that we assert in the ASTVerifier if we end up with inout-to-pointer being used for a raw pointer: https://github.com/apple/swift/blob/f8209f2865bb05d85aafb5c08e14960cfc6df042/lib/AST/ASTVerifier.cpp#L1400-L1407 |
xedin
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the commits which can land independently of #27695, with no intended functionality change.