[SyntaxParse] Re-apply move-only ParsedRawSyntaxNode to master #27707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please ASAN test |
|
@swift-ci Please test Windows |
rintaro
force-pushed
the
syntaxparse-rawnode-moveonly
branch
from
342a911 to
f321486
Compare
|
@swift-ci Please test Windows |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@compnerd Windows PR test is failing with an error https://ci-external.swift.org/job/swift-PR-windows/133/console Could you take a look? |
|
@swift-ci Please ASAN test |
|
@swift-ci Please test Windows |
|
Windows failure is unrelated. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reverting ASTGen changes (#27675).
This is still valuable for the master to prevent memory leaks.