[AutoDiff] Destroy all pullback indirect results after adjoint accumulation. #27711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lation. When we differentiate a function (example below) with respect to a proper subset of its indirect parameters and when the function only has a derivative with respecct to a superset of those indirect parameters, the pullback returns more indirect results that what we need. However, unneeded indirect results are not destroyed, which causes a memory lifetime verification failure. This patch fixes this bug by releasing all pullback indirect results instead of just releasing the ones needed for calculating the derivative. Resolves [TF-914](https://bugs.swift.org/browse/TF-914).
rxwei
commented
Oct 16, 2019
| // FIXME: The expression `(+) as @differentiable (Float, @nondiff Float) -> Float)` | ||
| // forms a curry thunk of `Float.+` before conversion to @differentiable, and AD | ||
| // doesn't know how to differentiate the curry thunk, so it produces a | ||
| // "function is not differentiable" error. | ||
| // FIXME: Propagate wrt indices correctly so that this actually takes the |
There was a problem hiding this comment.
This was referring to lowering parameter indices to @nondiff parameters, which was done long ago.
dan-zheng
approved these changes
Oct 16, 2019
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we differentiate a function (example below) with respect to a proper subset of its indirect parameters and when the function only has a derivative with respect to a proper superset of those indirect parameters, the pullback returns more indirect results than we need. However, unneeded indirect results are not destroyed, which causes a memory lifetime verification failure. This patch fixes this bug by releasing all pullback indirect results instead of just releasing the ones needed for calculating the derivative.
This patch also uncomments a test in test/AutoDiff/superset_adjoint.swift which is now passing. This fixed a FIXME.
Resolves TF-914.