[Diagnostics] Diagnose extraneous argument(s) via fixes #27728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are more arguments than parameters, let's fix this by ignoring (if possible) or removing extraneous arguments. Ignored arguments could default to `Any` if they don't get any other contextual type.
… to return all extraneous arguments
…CallArguments` Helps diagnostics to avoid digging this type out from locator.
Most importantly - index, label, and type, which are useful for diagnostics.
…tuple splat Before recording a generic "extraneous arguments" fix, let's check whether this is a tuple splat with a single parameter.
…missing/extra arguments This makes it possible to find all of the problems related to a given set of arguments and fix/score each overload candidate correctly.
In situations like:
```swift
func foo<T>(x: T) {}
foo(a; 0, x: 42)
```
Let's not try to fix call to `foo` as a tuple splat because match is
in a middle of the argument list, it should be considered a regular
extraneous argument instead.
Let's cover at least the most common cases - min/max. Fixing the problem requires refactoring of `resolveDeclRefExpr`.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
hborla
approved these changes
Oct 17, 2019
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are more arguments than parameters, let's fix this by
ignoring (if possible) or removing extraneous arguments. Ignored
arguments could default to
Any(be marked as a "hole") if theydon't get any other contextual type.
This also extends existing single extra argument to cover multiple
extraneous arguments.
Note that some of the diagnostics here regressed because of current
solver limitations, especially for name shadowing since it's impossible
to get access to outer overloads. I'm going to follow up with a
resolveDeclRefExprrefactoring to fix that problem.Resolves: rdar://problem/23948031
Resolves: rdar://problem/38827329
Resolves: rdar://problem/43351035
Resolves: rdar://problem/43848865
Resolves: rdar://problem/50927327
Resolves: rdar://problem/55254498