Rewrite some of the AD tests with Tracked<Float> #27733
Conversation
|
@swift-ci please test tensorflow |
| @@ -257,6 +257,34 @@ extension Tracked where T : Differentiable & FloatingPoint, T == T.TangentVector | |||
| } | |||
| } | |||
|
|
|||
| extension Tracked : VectorProtocol where T : SignedNumeric, T == T.Magnitude { | |||
There was a problem hiding this comment.
What test is using this conformance? VectorProtocol is not directly related to AD and cannot be upstreamed to master.
There was a problem hiding this comment.
Some AutoDiff tests reference VectorProtocol but I think all such references can be removed.
There was a problem hiding this comment.
This was needed for the protocol_requirement_autodiff.swift test. If we don't need VectorProtocol, I will go ahead and clean that up as well.
There was a problem hiding this comment.
You can try changing whatever requires VectorProtocol to require AdditiveArithmetic instead.
There was a problem hiding this comment.
Removed VectorProtocol here: #27734
Once that gets submitted, I will pull in the relevant changes.
There was a problem hiding this comment.
I reverted the changes to DifferentiationUnittest.swift
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
First of the several PRs that will enable leak checking for the AD tests.
https://bugs.swift.org/browse/TF-895