Skip to content

[reflection] Go back to 0/1 for bitwise_takable instead of false/true #27735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2019

Conversation

jrose-apple
Copy link
Contributor

I wanted to make the output nicer, so I asked @ismetanin to change to false/true in #27081, but it makes it harder to write tests that work across OS versions, so never mind.

rdar://problem/56350587

I wanted to make the output nicer, but it makes it harder to write
tests that work across OS versions, so never mind.

rdar://problem/56350587
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ac21ee4

@jrose-apple
Copy link
Contributor Author

SwiftPM failure? I don't think so.

@swift-ci Please test macOS

@rintaro rintaro merged commit 52f63a7 into swiftlang:master Oct 17, 2019
@jrose-apple jrose-apple deleted the false-friend branch October 17, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants