[AutoDiff] Mark SILGen derivative function thunks as "always inline". #27754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
force-pushed
the
autodiff-thunk-always-inline
branch
from
4c1cb80 to
175745b
Compare
rxwei
reviewed
Oct 17, 2019
dan-zheng
force-pushed
the
autodiff-thunk-always-inline
branch
from
175745b to
0e7f03f
Compare
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Oct 17, 2019
SILGen derivative function thunks must be publicly exposed and cannot be `[transparent]`. Instead, mark them as "always inline" for optimization.
dan-zheng
force-pushed
the
autodiff-thunk-always-inline
branch
from
5084eaa to
a6b9730
Compare
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILGen derivative function thunks must be publicly exposed and cannot be
[transparent]. Instead, mark them as "always inline" for optimization.Resolves TF-925.
Depends on #27752; rebase after it is merged.