Define InterfaceTypeRequest #27764
Merged
Define InterfaceTypeRequest #27764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The moment you've all been waiting for... Define InterfaceTypeRequest and use it to, well, compute the interface type. This naturally widens the few cycles that we pick up with the request evaluator. There is still a lot of work to get done here, mostly around scaling back all of the ad-hoc circularity checks around the interface type computation. It would also be great to improve the circularity diagnostics.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
⛵️ |
|
I believe that this has regressed the Windows build: asuhan@4fc20a4
|
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Oct 18, 2019
Avoid the use of the GNU extension for the collapsed ternary and use the explicit expansion. This should repair the Windows build.
|
Congratulations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that VarDecl's interface type computation is rationalized, the final piece was formalizing the
ParamDeclcase returning the nullType.Define a request for the interface type. This is not the end of this story by a long shot. The pattern binding request needs to be divided into a checked initializer request and a checked pattern request. The naming pattern request needs to do a lot less work by just checking one or the other. A bunch of places in the compiler have ad-hoc circularity breaking code that also needs to be swept up under the evaluator. The decl validation machinery still needs to be expunged.
There's a lot to do, but we can at least celebrate the little things.
🎉 validateDecl is dead! 🎉