[AutoDiff] Simplify logic for checking unmet generic requirements. #27783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SubstitutionMap` passed to `diagnoseUnsatisfiedRequirements` should default to the original function's forwarding substitution map. Delete the static `getSubstitutionMap` function, whose purpose is not clear and is not needed.
|
@swift-ci Please test tensorflow |
dan-zheng
commented
Oct 18, 2019
| @@ -2536,25 +2536,6 @@ reapplyFunctionConversion( | |||
| llvm_unreachable("Unhandled function conversion instruction"); | |||
| } | |||
|
|
|||
| static SubstitutionMap getSubstitutionMap( | |||
There was a problem hiding this comment.
More context: I added this getSubstitutionMap utility as a hack in #24845, I don't think the old behavior was necessary. The new simpler behavior seems sufficient for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SubstitutionMappassed todiagnoseUnsatisfiedRequirementsshould default to the original function's forwarding substitution map.
Delete the static
getSubstitutionMapfunction, whose purpose is not clearand is not needed.
Resolves bug exposed during WIP patch for retroactive derivative registration (TF-866).
I couldn't find a corresponding reproducer for testing on current
tensorflowbranch.