[SIL Optimization] Factor out a utility function: isConsumingUse from CopyPropagation.cpp into InstOptUtils.cpp. #27794
Conversation
from CopyPropagation.cpp into InstOptUtils.cpp. The function checks if a given use of a non-trivial, non-address SILValue will consume it i.e., decrease its reference count.
|
@swift-ci Please test |
|
@eeckstein I was thinking about this last night. When I was looking at the other PR, I wasn't sure where to put this since traditionally OwnershipUtils was just for OSSA code. But over time for certain things that has changed especially around the linear lifetime checker, so maybe it does make sense to put the declaration of this in ownership utils. Regardless of where we put this, I /do/ think that this should delegate to the OSSA tables if the function is in ownership SIL and then have a covered switch (or a table like thing) if we are not in OSSA. That way we get nice warnings/errors when we add new instructions. Still thinking about this a little though. |
@eeckstein If we are in ownership SIL yes this is exactly same as "MustBeInvalidated" flag of OperandOwnership Tables. But, I would like to also get this information when I am in non-ownership SIL. That is, I would like to know which operations are decrementing reference counts. I found that such a function was used in |
|
Closing this PR as this utility is not needed by the OSLogOptimization pass any more. |
The function checks if a given use of a non-trivial, non-address SILValue will consume it
i.e., decrease its reference count.
This function will be used by the OSLogOptimization pass while constant folding values. See this PR: #27744, function
replaceAllUsesAndFixLifetimes.