[Diagnostics] Move macros used in diagnostic definitions to their own header #27795
Conversation
| #undef ERROR | ||
| #undef FIXIT | ||
|
|
||
| #endif |
There was a problem hiding this comment.
It may be a good idea to keep this in the same header with a define to indicate that you want them undefined. That way they can be kept in sync. That said, new levels are unlikely to be introduced, so perhaps the complexity isnt worth it. Something to consider still.
There was a problem hiding this comment.
That's a good point. I'm still considering whether or not to extend these as part of some related diagnostics work. I think it's best to leave them as separate headers for now to keep things simple, but I'll reevaluate if it gets any more complicated.
owenv
force-pushed
the
diag_macro_refactor
branch
from
3d6b9cf to
0b09379
Compare
|
@swift-ci please test |
|
LGTM Please rebase this and we'll get it merged. |
owenv
force-pushed
the
diag_macro_refactor
branch
from
0b09379 to
161f4d0
Compare
… header These were duplicated in 11 different files, and as they've gotten more complex a few inconsistencies have snuck in. Sharing them should make future changes easier and less bug-prone.
owenv
force-pushed
the
diag_macro_refactor
branch
from
161f4d0 to
fdb6eab
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macOS |
|
@swift-ci test Windows |
1 similar comment
|
@swift-ci test Windows |
|
Merging this since it's a fairly mechanical change. Happy to address any feedback in a follow-up PR |
These were duplicated in 11 different files, and as they've gotten more complex a few inconsistencies have snuck in. Sharing them should make future changes easier and less bug-prone.