Skip to content

[AutoDiff] Add loop differentiation negative testcases. #27796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2019
Merged

[AutoDiff] Add loop differentiation negative testcases. #27796

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e535fd
Gardening: start iteration at index 0 instead of 1.
dan-zheng Oct 19, 2019
7e01076
[AutoDiff] Add loop differentiation negative testcases.
dan-zheng Oct 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions test/AutoDiff/control_flow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,18 +522,32 @@ ControlFlowTests.test("Enums") {
ControlFlowTests.test("Loops") {
func for_loop(_ x: Float) -> Float {
var result = x
for _ in 1..<3 {
for _ in 0..<2 {
result = result * x
}
return result
}
expectEqual((8, 12), valueWithGradient(at: 2, in: for_loop))
expectEqual((27, 27), valueWithGradient(at: 3, in: for_loop))

func for_loop_nonactive_initial_value(_ x: Float) -> Float {
var result: Float = 1
for _ in 0..<2 {
result = result * x
}
return result
}
// TODO(TF-933): Fix incorrect derivatives when `var result` is not initially
// assigned to `x`.
// expectEqual((4, 4), valueWithGradient(at: 2, in: for_loop_nonactive_initial_value))
// expectEqual((9, 6), valueWithGradient(at: 3, in: for_loop_nonactive_initial_value))
expectEqual((4, 2), valueWithGradient(at: 2, in: for_loop_nonactive_initial_value))
expectEqual((9, 3), valueWithGradient(at: 3, in: for_loop_nonactive_initial_value))

func while_loop(_ x: Float) -> Float {
var result = x
var i = 1
while i < 3 {
var i = 0
while i < 2 {
result = result * x
i += 1
}
Expand All @@ -544,11 +558,11 @@ ControlFlowTests.test("Loops") {

func repeat_while_loop(_ x: Float) -> Float {
var result = x
var i = 1
var i = 0
repeat {
result = result * x
i += 1
} while i < 3
} while i < 2
return result
}
// FIXME(TF-584): Investigate incorrect (too big) gradient values
Expand Down Expand Up @@ -586,12 +600,12 @@ ControlFlowTests.test("Loops") {

func nested_loop1(_ x: Float) -> Float {
var outer = x
for _ in 1..<3 {
for _ in 0..<2 {
outer = outer * x

var inner = outer
var i = 1
while i < 3 {
var i = 0
while i < 2 {
inner = inner + x
i += 1
}
Expand All @@ -604,11 +618,11 @@ ControlFlowTests.test("Loops") {

func nested_loop2(_ x: Float, count: Int) -> Float {
var outer = x
outerLoop: for _ in 1..<count {
outerLoop: for _ in 0..<count {
outer = outer * x

var inner = outer
var i = 1
var i = 0
while i < count {
inner = inner + x
i += 1
Expand All @@ -623,8 +637,8 @@ ControlFlowTests.test("Loops") {
}
return outer
}
expectEqual((24, 12), valueWithGradient(at: 2, in: { x in nested_loop2(x, count: 5) }))
expectEqual((16, 8), valueWithGradient(at: 4, in: { x in nested_loop2(x, count: 5) }))
expectEqual((24, 12), valueWithGradient(at: 2, in: { x in nested_loop2(x, count: 4) }))
expectEqual((16, 8), valueWithGradient(at: 4, in: { x in nested_loop2(x, count: 4) }))
}

runAllTests()