[NFC] Remove AbstractFunctionDecl::computeType() #27806
Conversation
|
@swift-ci please test and merge |
|
Types Are Hard. |
| @@ -750,7 +750,9 @@ static FuncDecl *deriveEncodable_encode(DerivedConformance &derived) { | |||
| encodeDecl->getAttrs().add(attr); | |||
| } | |||
|
|
|||
| encodeDecl->computeType(FunctionType::ExtInfo().withThrows()); | |||
There was a problem hiding this comment.
Ah, these aren't correct. The throws bit goes on the inner function type.
There was a problem hiding this comment.
You need to store the throws bit somewhere now.
There was a problem hiding this comment.
The throwing bit gets applied to the ext info based on whether the throwing bit is set in the function decl. Both the changed places in the Codable conformance synthesis stuff are already setting that.
Its functionality is entirely subsumed by InterfaceTypeRequest.
CodaFi
force-pushed
the
it-isnt-about-computers-and-it-isnt-about-science
branch
from
dc9ef49 to
497a222
Compare
|
@swift-ci please smoke test |
| @@ -177,7 +176,7 @@ getBuiltinFunction(Identifier Id, ArrayRef<Type> argTypes, Type ResType, | |||
| /*GenericParams=*/nullptr, | |||
| paramList, | |||
| TypeLoc::withoutLoc(ResType), DC); | |||
| FD->computeType(Info); | |||
| (void)FD->getInterfaceType(); | |||
There was a problem hiding this comment.
None of the new calls to (void)fn->getInterfaceType() should be necessary. Were you not able to remove them?
There was a problem hiding this comment.
I'm bad at rebasing, and when I was writing this up this morning I must have built on top of a bad revision. I think these can all go away now.
|
Talked with Slava out-of-band. Going to land removing the calls to |
|
⛵️ |
Its functionality is entirely subsumed by InterfaceTypeRequest.