[TSan] Do not report benign race on _swiftEmptyArrayStorage
#27808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit [1] identified and fixed a benign race on `_swiftEmptyArrayStorage`. Unfortunately, we have some code duplication and the fix was not applied to all the necessary places. Essentially, we need to ensure that the "empty array storage" object that backs many "array like types" is never written to. I tried to improve the test to capture this, however, it is very finicky. Currently, it does not go red on my system even when I remove the check to avoid the benign race in Release mode. Relevant classes: Array, ArraySlice, ContiguousArray, ArrayBuffer, ContiguousArrayBuffer, SliceBuffer. [1] b9b4c78 rdar://55161564
yln
requested review from
kubamracek,
mikeash,
jrose-apple,
jckarter,
xymus,
airspeedswift and
devincoughlin
|
Also: it might be worth to reduce/remove this code duplication, if possible. |
Remove the argument label to reduce the verbosity in the test.
|
@swift-ci please test |
jrose-apple
requested review from
lorentey and
Catfish-Man
and removed request for
jrose-apple
lorentey
approved these changes
Oct 21, 2019
|
@swift-ci Please test Linux platform |
|
I'm a bit late, but this looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit [1] identified and fixed a benign race on
_swiftEmptyArrayStorage. Unfortunately, we have some code duplicationand the fix was not applied to all the necessary places. Essentially,
we need to ensure that the "empty array storage" object that backs many
"array like types" is never written to.
I tried to improve the test to capture this, however, it is very
finicky. Currently, it does not go red on my system even when I remove
the check to avoid the benign race in Release mode.
Relevant classes: Array, ArraySlice, ContiguousArray, ArrayBuffer,
ContiguousArrayBuffer, SliceBuffer.
[1] b9b4c78
rdar://55161564