Skip to content

[build-script] Don't build StdlibUnittest when building SwiftPM #27813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 21, 2019

@aciidb0mb3r If you decide that the stdlib unit tests should not be built when building SwiftPM, this PR removes it from the preset.

@ahoppen ahoppen requested a review from aciidgh October 21, 2019 21:11
@ahoppen
Copy link
Member Author

ahoppen commented Oct 21, 2019

@swift-ci Please smoke test

@ahoppen
Copy link
Member Author

ahoppen commented Oct 21, 2019

Running the SwiftPM test suite.

preset=buildbot_swiftpm_macos_platform,tools=RA,stdlib=RA
@swift-ci Please test with preset macOS Platform

Copy link
Contributor

@aciidgh aciidgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahoppen ahoppen merged commit 6904dba into swiftlang:master Oct 21, 2019
@ahoppen ahoppen deleted the dont-build-stdlib-unittest-extra branch October 21, 2019 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants