Skip to content

[build-script] Add preset to set up CI testing for the stress tester #27817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2019
Merged

[build-script] Add preset to set up CI testing for the stress tester #27817

merged 3 commits into from
Oct 23, 2019

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 21, 2019 •
edited
Loading

This configures a preset buildbot_skstresstester_macos that can be used for CI testing of the stress tester.

This does not yet set up testing the stress tester as a downstream dependency of the Swift and SwiftSyntax project.

@ahoppen ahoppen force-pushed the skstresstester-ci-testing branch from 150719e to 01f7d0a Compare October 21, 2019 22:30
@ahoppen
Copy link
Member Author

ahoppen commented Oct 21, 2019

preset=buildbot_skstresstester_macos
@swift-ci Please test with preset macOS Platform

@ahoppen ahoppen changed the title [build-script] Add preset to set up CI testing for the stress tester WIP: [build-script] Add preset to set up CI testing for the stress tester Oct 21, 2019
@ahoppen
Copy link
Member Author

ahoppen commented Oct 22, 2019

There have been a couple changes to the SwiftSyntax and stress tester repositories. Let’s just verify again.

preset=buildbot_skstresstester_macos
@swift-ci Please test with preset macOS Platform

@ahoppen
Copy link
Member Author

ahoppen commented Oct 22, 2019

And get this PR green.

@swift-ci Please smoke test

@ahoppen ahoppen changed the title WIP: [build-script] Add preset to set up CI testing for the stress tester [build-script] Add preset to set up CI testing for the stress tester Oct 22, 2019
@ahoppen ahoppen requested a review from shahmishal October 22, 2019 22:23
@shahmishal
Copy link
Member

Is there a reason for deleting buildbot_swiftevolve_macos preset?

@ahoppen
Copy link
Member Author

ahoppen commented Oct 22, 2019

I only added it a couple days ago and now realized that there is never a situation where we only want to test one of the two since they both live in the same repository.

@ahoppen
Copy link
Member Author

ahoppen commented Oct 22, 2019

Building the stress tester failed because the sources in SwiftSyntax master-gen were not up-to-date. Let’s try again.

preset=buildbot_skstresstester_macos
@swift-ci Please test with preset macOS Platform

@ahoppen
Copy link
Member Author

ahoppen commented Oct 23, 2019

preset=buildbot_skstresstester_macos
@swift-ci Please test with preset macOS Platform

@ahoppen ahoppen merged commit 985ed1a into swiftlang:master Oct 23, 2019
@ahoppen ahoppen deleted the skstresstester-ci-testing branch October 23, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @shahmishal