Vim syntax highlighting improvements #2782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A typename is a name for a type being defined. A type may contain optionality as well. This ensures that we do not accidentally highlight an invalid name such as `InvalidName?` as a type name. Fix the fact that I had previously created a special group for the array. An array is a type, so it should be part of the same group.
We currently only do init<T>. Only permit generalization of init, not deinit, subscript.
Perform more clever highlighting of generic clauses. The archetype identifier is now identified as an identifier, the archtetype type as a type, and the constraints (where) as special syntax.
Check for a type declaration following an attribute. This corrects the highlighting of function types such as: @NoEscape (Wrapped) throws -> T
Swift permits the use of reserved keywords as identifiers. Reflect that in the syntax highlighting.
|
|
||
| syn region swiftTypeParameters start="<" end=">" contained | ||
| syn keyword swiftNew skipwhite nextgroup=swiftTypeName | ||
| \ new |
There was a problem hiding this comment.
I think new is historic. Please feel free to drop it.
|
Bug report: try opening |
|
Hmm, I will look into the issue you pointed out. The immediate idea that I have works for that but breaks the parameter list in function declarations :-(. lll also drop new. |
MaxDesiatov
pushed a commit
that referenced
this pull request
Apr 19, 2021
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.