Skip to content

Fix memory error in the implementation of IndexSubset. #27832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

bgogul
Copy link
Contributor

@bgogul bgogul commented Oct 22, 2019

Fixes rdar://problem/56338898

@bgogul
Copy link
Contributor Author

bgogul commented Oct 22, 2019

@swift-ci please smoke test

@bgogul bgogul requested review from rintaro and dan-zheng October 22, 2019 06:53
@rintaro
Copy link
Member

rintaro commented Oct 22, 2019

@swift-ci Please ASAN test

Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks for fixing this!

@dan-zheng dan-zheng requested a review from rxwei October 23, 2019 05:39
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgogul: could you please also cherry pick this patch to tensorflow branch? Thanks 🙂

@DougGregor DougGregor merged commit eb0b307 into swiftlang:master Oct 23, 2019
@bgogul bgogul deleted the fix_asan_errors branch October 23, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants