[build-script] Don't build stdlib for iOS if --skip-build-ios is passed #27840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
aciidgh
approved these changes
Oct 22, 2019
|
@swift-ci build toolchain macOS |
|
preset=buildbot_swiftpm_macos_platform,tools=RA,stdlib=RA |
|
Using this PR to test changes to SwiftEvolve. preset=buildbot_swiftevolve_macos |
|
Using this PR to test changes to SwiftEvolve. swiftlang/swift-stress-tester#92 preset=buildbot_swiftevolve_macos |
|
Test SwiftEvolve again. swiftlang/swift-stress-tester#92 preset=buildbot_swiftevolve_macos |
|
@swift-ci build toolchain macOS |
|
macOS Toolchain Install command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
--skip-build-iosis passed, we should not build anything that is iOS related. This includes the standard library. However, we have so far been ignoring the flag for the standard library builds. This PR fixes this. The same also applies for watchOS and tvOS.Disclaimer: I am not quite sure if this will break some bots that relied on the standard library being there. If any break, we should go and update the presets or revert this PR.