SwiftSyntax: Commit gyb-generated files to master #27841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed-files This will allow us to set up a CI bot that can test that all generated sources in SwiftSyntax are up-to-date.
…s all generated files We no longer need to generate the files using gyb. Instead we should check that the generated files are actually up-to-date.
|
@swift-ci Please test |
ahoppen
changed the title
|
Build failed |
|
Build failed |
|
@swift-ci Please smoke test |
|
Just realized I hadn't updated the generated files to match. Let's restart the test. @swift-ci Please smoke test |
|
Swift-CI didn’t pull in the SwiftSyntax sources. Try again. @swift-ci Please smoke test |
|
Test failure seemed unrelated. Let’s try one more time. @swift-ci Please smoke test macOS platform |
|
The bug causing CI tests to fail should be fixed now @swift-ci Please smoke test macOS platform |
nkcsgexi
approved these changes
Oct 25, 2019
nkcsgexi
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR to swiftlang/swift-syntax#159. It adds the necessary flags to forward
--swiftsyntax-verify-generated-filesand adds a preset with which we can test SwiftSyntax in CI. At the moment SwiftSyntax is using a hard-baked command in CI.