Skip to content

[windows] Add folder to path while testing. #27844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

drodriguez
Copy link
Contributor

Some DLL are not installed, since they are only used for testing, but
they need to be in the PATH to allow some test binaries to execute
properly.

The test happened in CI because _InternalSwiftSyntaxParser.dll is not installed, and sits in %build_root%\swift\bin.

lit.py: C:\jenkins\workspace\oss-swift-windows-x86_64\llvm\utils\lit\lit\formats\googletest.py:43: warning: unable to discover google-tests in 'S:\\swift\\unittests\\SyntaxParser\\.\\SwiftSyntaxParserTests.exe': Command '['S:\\swift\\unittests\\SyntaxParser\\.\\SwiftSyntaxParserTests.exe', '--gtest_list_tests']' returned non-zero exit status -1073741515. Process output:

Some DLL are not installed, since they are only used for testing, but
they need to be in the PATH to allow some test binaries to execute
properly.
@drodriguez drodriguez requested a review from compnerd October 23, 2019 01:02
@drodriguez
Copy link
Contributor Author

The Error 87 will probably still happen. The error from 27823 should still happen, as well as 27843 (intentionally not linking those two to avoid problems with the CI bot).

@swift-ci please test Windows platform

@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test

@compnerd compnerd merged commit 355a25a into swiftlang:master Oct 24, 2019
@drodriguez drodriguez deleted the windows-modify-testing-path branch October 24, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants