Allow running iphoneos-armv7s tests #2785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guration was running all tests A nested loop was adding arguments specific to the current iteration to a variable, where the arguments persisted into the next iteration. The issue only affected the only_validation-only_non_executable configuration, here's why. The test subsets were configured in the following order: primary, validation, all, only_validation, only_long. The first three were not adding new arguments. 'all' was adding arguments that were affecting 'only_validation'. Then 'only_long' was adding an argument of its own that was overriding the argument from 'all'.
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2497 has uncovered that iphoneos-armv7s test configuration was never run. The refactoring in that pull request has fixed that bug, and now the armv7s tests are being run, but since there are other issues, the tests fail. This pull request fixes those issues.
Changes were tested with:
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.