[TF-935] Replaces '-Xllvm -run-jvp-generation' by '-enable-experiment… #27861
Conversation
| @@ -358,6 +358,9 @@ static bool ParseLangArgs(LangOptions &Opts, ArgList &Args, | |||
| if (Args.hasArg(OPT_experimental_dependency_include_intrafile)) | |||
| Opts.ExperimentalDependenciesIncludeIntrafileOnes = true; | |||
|
|
|||
| // TODO: Ignore if enable-experimental-differentiable-programming is false | |||
There was a problem hiding this comment.
From what I've seen in the code {{-enable-experimental-differentiable-programming}} has been added as frontend option but is not really taken into account to enable/disable AutoDiff capabilities. As soon as the opt is taken into account, we can update this to disable {{EnableExperimentalForwardModeDifferentation}} accordingly.
…al-forward-mode-differentiation'. -enable-experimental-forward-mode-differentiation is a frontend option that is clearer on it's intent and more accessible. It defaults to false. Resolves [TF-935](https://bugs.swift.org/browse/TF-935).
| @@ -231,6 +231,8 @@ static void addCommonFrontendArgs(const ToolChain &TC, const OutputInfo &OI, | |||
| options::OPT_enable_experimental_dependencies); | |||
| inputArgs.AddLastArg(arguments, | |||
| options::OPT_experimental_dependency_include_intrafile); | |||
| inputArgs.AddLastArg( | |||
There was a problem hiding this comment.
Ooo, is inputArgs.AddLastArg missing for options::OPT_enable_experimental_differentiable_programming? I'm not sure whether adding it is necessary, but it seems necessary.
There was a problem hiding this comment.
indeed it is missing and it seems to be necessary but since the option is not used anywhere in the code yet (#27446). Honestly, I am not sure what the consequences are of not doing inputArgs.AddLastArg.
There was a problem hiding this comment.
Honestly, I am not sure what the consequences are of not doing
inputArgs.AddLastArg.
Me neither 😮
|
thank you for the review @dan-zheng, I addressed your comments on 6527605 |
Co-Authored-By: Richard Wei <[email protected]>
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
…al-forward-mode-differentiation'.
-enable-experimental-forward-mode-differentiation is a frontend option that is clearer on it's intent and more
accessible. It defaults to false.
Resolves TF-935.