Skip to content

[Runtime] Add a function pointer for intercepting swift_willThrow calls. #27863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2019
Merged

[Runtime] Add a function pointer for intercepting swift_willThrow calls. #27863

merged 2 commits into from
Oct 29, 2019

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Oct 24, 2019

rdar://problem/53400364

@mikeash mikeash mentioned this pull request Oct 24, 2019
Closed
@mikeash mikeash force-pushed the will-throw-callback branch from dbf4849 to b8f5e84 Compare October 24, 2019 18:06
jckarter
jckarter approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jckarter jckarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a lot better for a tools-only hook, thanks!

@mikeash
Copy link
Contributor Author

mikeash commented Oct 24, 2019

@jckarter thank you for your valuable feedback!

stmontgomery
stmontgomery approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@stmontgomery stmontgomery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@mikeash
Copy link
Contributor Author

mikeash commented Oct 25, 2019

@swift-ci please test

@mikeash
Copy link
Contributor Author

mikeash commented Oct 25, 2019

@swift-ci please test windows platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b8f5e84

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b8f5e84

@mikeash
Copy link
Contributor Author

mikeash commented Oct 28, 2019

@swift-ci please test

@mikeash
Copy link
Contributor Author

mikeash commented Oct 28, 2019

@swift-ci please test windows platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - b8f5e84

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - b8f5e84

@mikeash
Copy link
Contributor Author

mikeash commented Oct 29, 2019

@swift-ci please test windows platform

@mikeash
Copy link
Contributor Author

mikeash commented Oct 29, 2019

The Windows failure looks unrelated so I'll merge this.

@mikeash mikeash merged commit 55f9d2a into swiftlang:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@jckarter jckarter jckarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeash @swift-ci @stmontgomery @jckarter