[test] Add test case for convenience init inheritance #27882
Merged
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case tripped up an attempt I made to simplify addImplicitInheritedConstructorsToClass for clang decls. Add it to the test suite to make sure we don't regress it.
|
@swift-ci please smoke test |
|
That is a wacky test case and I would hope it never comes up in real life. Does it, though? |
|
@jrose-apple Yeah, I managed to reduce this down after hitting a similar case in CloudKit.
|
|
@swift-ci please smoke test OS X platform |
|
😢 Okay, thanks for identifying it, then. |
jrose-apple
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case tripped up an attempt I made to simplify
addImplicitInheritedConstructorsToClassfor clang decls. Add it to the test suite to make sure we don't regress it.