[SIL Optimization] Fix a bug in isAliveAtBeginOfBlock function of ValueLifetimeAnalysis and generalize the utility #27892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of ValueLifetimeAnalysis and generalize the utility so that it can provide the critical edges as well, when it is invoked in DoNotModifyCFG mode.
|
@swift-ci Please test |
This was referenced Oct 26, 2019
Merged
atrick
approved these changes
Oct 26, 2019
There was a problem hiding this comment.
Awesome! Your comments are especially good.
FYI, many passes simply call splitCriticlEdges() before hand to avoid complexity. I recommend you do that too. The only thing keeping me from prohibiting critical edges in the SIL verifier is that I need to update a ton on SIL test cases first. Critical edges in mid-level IR are ridiculous, let alone high level IR like SIL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that it can provide the critical edges as well, when it is invoked in DoNotModifyCFG mode.