[ClangImporter] Diagnose bad swift_name attributes better #27924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emitting Swift diagnostics in Clang buffers requires making those buffers valid places to put Swift SourceLocs, which means making a mirror of those buffers in the Swift SourceManager. This isn't a copy; instead, any Clang SourceManagers that are involved are kept alive until the importer is torn down. (There might be more than one because of diagnostics emitted during module building.) For a long time we only emitted diagnostics in Clang buffers if the diagnostics came from Clang, but then we added another case for custom Swift names that fail to import. I'm about to add another such diagnostic, so let's formalize this buffer mapping first. No intended functionality change.
1. Set the diagnostic location to where the attribute was written (or to the Clang decl's source, if the attribute came from API notes) 2. Add a note to contact the owners of the framework to make it clear that the client of the framework didn't do anything wrong. rdar://problem/52736145
jrose-apple
requested review from
xymus,
beccadax,
DougGregor and
varungandhi-apple
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
xymus
approved these changes
Oct 29, 2019
|
What prompted this one is we (Apple) shipped mistakes of this kind at WWDC (oops). What makes the extra note important is that we know there's a custom name—i.e., someone wrote a name explicitly—but that custom name was wrong. There might be a few other places where that's relevant, yeah. |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test macOS |
DougGregor
approved these changes
Oct 30, 2019
beccadax
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the diagnostic location to where the attribute was written (or to the Clang decl's source, if the attribute came from API notes). This required a bit of reworking in the first commit to make it easier to emit Swift diagnostics in Clang buffers.
Add a note to contact the owners of the framework to make it clear that the client of the framework didn't do anything wrong.
rdar://problem/52736145