Skip to content

Many Things Don't Need a TypeChecker Part 2 #27946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamishknight
Copy link
Contributor

This PR changes AttributeChecker and UnsupportedProtocolVisitor to not store TypeChecker properties, and makes a handful of TypeChecker members static.

@hamishknight
Copy link
Contributor Author

@swift-ci please smoke test

@hamishknight hamishknight force-pushed the checking-out-where-i-left-off branch from 27f9909 to 34ce9bd Compare October 30, 2019 15:09
Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@hamishknight
Copy link
Contributor Author

@swift-ci please smoke test

@hamishknight hamishknight merged commit d9ca3be into swiftlang:master Oct 30, 2019
@hamishknight hamishknight deleted the checking-out-where-i-left-off branch October 30, 2019 18:53
dan-zheng pushed a commit to dan-zheng/swift that referenced this pull request Oct 30, 2019
Many Things Don't Need a TypeChecker Part 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants