Skip to content

[NFC] Strip Witness Matching of its TypeChecker #27969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2019
Merged

[NFC] Strip Witness Matching of its TypeChecker #27969

merged 2 commits into from
Oct 31, 2019

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Oct 30, 2019 •
edited
Loading

In order to do this, push the last remaining TypeChecker dependency on swift::matchWitness to the call sites and downgrade the TypeChecker in the matchers to an ASTContext. This also removes a TypeChecker cache by defining CompareDeclSpecializationRequest, which now powers isDeclAsSpecializedAs.

@CodaFi CodaFi requested a review from slavapestov October 30, 2019 21:19
@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 30, 2019

@swift-ci please test

CodaFi added 2 commits October 30, 2019 15:10
@CodaFi
Add CompareDeclSpecializationRequest
3753a96
@CodaFi
[NFC] Strip witness checking of its type checker
e3e4399 
Push dependencies down to their use sites and downgrade the TypeCheckers in witness matching to ASTContexts.
@CodaFi CodaFi force-pushed the witless-witnesses branch from efda33f to e3e4399 Compare October 30, 2019 22:10
@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 30, 2019

@swift-ci please smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 30, 2019

Old full test is occurring here

@CodaFi
Copy link
Contributor Author

CodaFi commented Oct 31, 2019

⛵️

@CodaFi CodaFi merged commit d9ea4ec into swiftlang:master Oct 31, 2019
@CodaFi CodaFi deleted the witless-witnesses branch October 31, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov Awaiting requested review from slavapestov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CodaFi